Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Adding InstanceFailoverGroups #2615

Merged
merged 3 commits into from
Mar 20, 2018
Merged

[DO NOT MERGE] Adding InstanceFailoverGroups #2615

merged 3 commits into from
Mar 20, 2018

Conversation

jugeorge
Copy link
Contributor

@jugeorge jugeorge commented Mar 8, 2018

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@AutorestCI
Copy link

AutorestCI commented Mar 8, 2018

Automation for azure-sdk-for-node

Nothing to generate for azure-sdk-for-node

@AutorestCI
Copy link

AutorestCI commented Mar 8, 2018

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#1950

@AutorestCI
Copy link

AutorestCI commented Mar 8, 2018

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#1356

@jhendrixMSFT
Copy link
Member

@AutorestCI rebuild azure-sdk-for-go

@AutorestCI
Copy link

AutorestCI commented Mar 19, 2018

Automation for azure-libraries-for-java

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-libraries-for-java#292

@jhendrixMSFT
Copy link
Member

@AutorestCI rebuild azure-sdk-for-go

}
],
"properties": {
"properties": {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to have properties within properties?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this right? Outer "properties" is swagger syntax, inner "properties" is the name of the actual json element.

@alvadb alvadb merged commit 0f14920 into Azure:master Mar 20, 2018
}
],
"properties": {
"properties": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this right? Outer "properties" is swagger syntax, inner "properties" is the name of the actual json element.

}
}
},
"ManagedInstancePairInfo": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be changed to just ManagedInstancePair ? "Info" seems redundant. All objects are information about something.

}
}
},
"PartnerRegionInfo": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment about "Info" here

@lmazuel
Copy link
Member

lmazuel commented Mar 20, 2018

@AutorestCI regenerate azure-sdk-for-python

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants